-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L13: gRPC Python Client and Server Interceptors #39
Conversation
@nathanielmanistaatgoogle please approve so that this proposal can be merged in a timely manner. |
I need to make modifications to it. The API has somewhat changed. Please hold off on reviewing it. I have not forgotten. |
Thanks for the work on this feature, it will allow me to remove considerable boilerplate. |
@naggie Yes, we pursued this proposal and captured some user feedback and an experimental version (which will very likely become final after marking this proposal as approved) is merged already and is ready to use. I still need to update this proposal to incorporate the feedback and update it to match the version that we shipped since 1.8. |
For consistency, please rename this file to |
@mehrdada Can you take some time to update the server interceptor section to match the implementation? We want to make interceptor API stable, and it will be great to make this gRFC a reference of its rationale/design. |
@lidizheng I don't think I am going to have any free time to spend on that, sorry. Feel free to fork it and make it your own; I don't mind. Just to point out one thing you need to figure out that users have asked for is (my memory is a bit fuzzy but it has to be somewhere in the issues) how the interceptors can detect whether an exception thrown is an abortion or not, if I remember correctly. |
Addresses grpc/grpc#8767
Implementation: grpc/grpc#12778
Discussion: https://groups.google.com/d/msg/grpc-io/7qIzyCPWbUA/1NKGXAQHCgAJ