-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build different binaries for different libc’s (a.k.a. support alpine linux) #82
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
CLA signed. |
CLAs look good, thanks! |
Can you make the corresponding change to |
Thanks for spotting that. Done in 4479312. |
I think it would make a lot of sense to have a precompiled musl build to save on build dependencies. |
Is there anything else I can do to push this forward? |
Is there any way this can get merged? We are running into this problem with a number of our images currently. Thanks for the fix! |
Same here, delaying deploys of some features too. :) |
Any prediction of launch new version? |
The latest version of node-pre-gyp supports using
libc
as a variable for binary names, making it possible to differentiate between glibc and musl of alpine linux.Fixes #81.