Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UNIMPLEMENTED details when an RPC method is not impl. #207

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Add UNIMPLEMENTED details when an RPC method is not impl. #207

merged 1 commit into from
Mar 14, 2018

Conversation

theogravity
Copy link
Contributor

Had a situation where a test GRPC client was sending to a RPC method that did not yet exist on our GRPC server, resulting in an unclear error from the GRPC server:

unhandledRejection { Error: 12 UNIMPLEMENTED: 
    at new createStatusError (/Users/t.gravity/xxx/node_modules/grpc/src/client.js:64:15)
    at /Users/t.gravity/xxx/node_modules/grpc/src/client.js:583:15
  code: 12,
  metadata: Metadata { _internal_repr: {} },
  details: '' }

It was a bit difficult to debug as the testing client was sending multiple events - this PR adds some clarification to which RPC method was being called that was not implemented.

With the update, we would now get clarification:

unhandledRejection { Error: 12 UNIMPLEMENTED: RPC method not implemented: /test.TestService/Metrics
    at new createStatusError (/Users/t.gravity/xxx/node_modules/grpc/src/client.js:64:15)
    at /Users/t.gravity/xxx/node_modules/grpc/src/client.js:583:15
  code: 12,
  metadata: Metadata { _internal_repr: {} },
  details: 'RPC method not implemented: /test.TestService/Metrics' }

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@theogravity
Copy link
Contributor Author

CLA signed.

@murgatroid99 murgatroid99 merged commit 896f07c into grpc:master Mar 14, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants