Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server builders extend public API #7386

Merged
merged 3 commits into from
Sep 3, 2020

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented Aug 31, 2020

The second part of #7211: Hide AbstractServerImplBuilder from public API.
Ref the first part: #7359.

@sergiitk sergiitk changed the title Server builders extend forwarding various: Server builders extend public API Sep 1, 2020
@sergiitk sergiitk changed the title various: Server builders extend public API Server builders extend public API Sep 1, 2020
@sergiitk sergiitk force-pushed the server-builders-extend-forwarding branch 4 times, most recently from b0ecb61 to c3793c0 Compare September 2, 2020 22:02
@sergiitk sergiitk requested a review from ejona86 September 2, 2020 22:04
@sergiitk
Copy link
Member Author

sergiitk commented Sep 2, 2020

TODO: create @ExperimentalApi issue for ForwardingServerBuilder.
EDIT: done, #7393.

@sergiitk sergiitk force-pushed the server-builders-extend-forwarding branch from 66de42b to 236611e Compare September 3, 2020 19:09
@sergiitk sergiitk force-pushed the server-builders-extend-forwarding branch 3 times, most recently from 85158c7 to 45702db Compare September 3, 2020 19:15
@sergiitk sergiitk force-pushed the server-builders-extend-forwarding branch from 45702db to 90b6306 Compare September 3, 2020 19:29
@sergiitk sergiitk force-pushed the server-builders-extend-forwarding branch from 90b6306 to 1e2c460 Compare September 3, 2020 19:40
@sergiitk sergiitk merged commit 3493347 into grpc:master Sep 3, 2020
@sergiitk sergiitk deleted the server-builders-extend-forwarding branch September 3, 2020 20:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants