Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xdsclient: ignore routes with cluster_specifier_plugin when GRPC_EXPERIMENTAL_XDS_RLS_LB is off #5670

Merged
merged 1 commit into from
Sep 23, 2022
Merged

xdsclient: ignore routes with cluster_specifier_plugin when GRPC_EXPERIMENTAL_XDS_RLS_LB is off #5670

merged 1 commit into from
Sep 23, 2022

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Sep 23, 2022 •
edited
Loading

This PR implements changes mentioned in grpc/proposal#292.

RELEASE NOTES:

  • xdsclient: fix a bug which was causing routes with cluster_specifier_plugin set to be NACKed when GRPC_EXPERIMENTAL_XDS_RLS_LB was off

@easwars easwars added this to the 1.50 Release milestone Sep 23, 2022
@easwars easwars requested a review from dfawley September 23, 2022 18:48
@easwars easwars marked this pull request as ready for review September 23, 2022 18:48
@easwars easwars merged commit 8458251 into grpc:master Sep 23, 2022
@easwars easwars deleted the rls_csps_fix branch September 23, 2022 20:26
@moul-bot moul-bot mentioned this pull request Oct 7, 2022
Closed
@moul-bot moul-bot mentioned this pull request Oct 17, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@dfawley dfawley

Labels
Type: Bug
Projects
None yet
Milestone
1.50 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@easwars @dfawley