Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX fixes: fact table SQL editing, paginated metric and member lists #3233

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

jdorn
Copy link
Member

@jdorn jdorn commented Nov 1, 2024

Features and Changes

  • Always show fact table SQL on the page instead of collapsing by default and show next to columns
  • "Edit SQL" link for fact tables now directly opens the SQL editor instead of requiring a 2nd click
  • You no longer need to specify Identifier Types when editing a fact table. They are detected automatically from the SQL that is entered.
  • Add pagination to several pages: Metrics, Members, Fact Table columns, Fact Table filters, Reports
  • Update README for front-end package documenting new pagination options and fixing outdated form info

image

items: columns,
defaultSortField: "dateCreated",
localStorageKey: "factColumns",
searchFields: ["name^3", "description", "column^2"],
pageSize: 5,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, maybe this should be a little bit dynamic, dependent on the length of the SQL? Not sure how hard that is.

@jdorn jdorn merged commit 515b6f2 into main Nov 1, 2024
3 checks passed
@jdorn jdorn deleted the jd/fact-table-ux-fixes branch November 1, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants