Added namespace ids and label #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your preview environment pr-2670-bttf has been deployed. Preview environment endpoints are available at: |
jdorn
reviewed
Jun 21, 2024
| className="italic text-danger" | ||
| title="this namespace is not found" | ||
| > | ||
| phase.namespace.name |
|
The other part of that linked issue is that if someone created a namespace that has a special character in the name like |
… problem on editing and deleting. Fixed missing curley braces
jdorn
approved these changes
Jun 21, 2024
lukebrawleysmith
pushed a commit
that referenced
this pull request
Jul 24, 2024
Allowed editing names after adding to experiments. Fixed url encoding problem when editing and deleting. Fixed missing curly braces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits label from the id for namespaces so that the label can be edited without reassigning users or causing reference errors.
Fixes #2666