Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check license key first on license refresh. #2294

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

tzjames
Copy link
Collaborator

@tzjames tzjames commented Mar 27, 2024

Features and Changes

For cloud users who had pro trial/pro but then cancelled, we allow them currently to still sign up for a new license. Not ideal, but that will go away once we fully migrate and remove old license data.
But in the mean time when trying to update the license we were checking first the old subscription, which being cancelled ended up returning an error that was caught and nothing changed.

Testing

create an organization in GB while manually adding "subscription" object.
Update the license in retool/locally running license server.
Go to general settings and hit refresh on the license and see the new data.

@tzjames tzjames requested a review from mknowlton89 March 27, 2024 15:11
Copy link

Your preview environment pr-2294-bttf has been deployed.

Preview environment endpoints are available at:

@tzjames tzjames merged commit 9191fbb into main Mar 28, 2024
3 checks passed
@tzjames tzjames deleted the ji/licenseKeyFirst branch March 28, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants