test thread sync

grimmpp · May 14, 2024 · bf0882e · bf0882e
1 parent 4328585
commit bf0882e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 12 deletions.
diff --git a/custom_components/eltako/gateway.py b/custom_components/eltako/gateway.py
@@ -93,9 +93,8 @@ def set_connection_state_changed_handler(self, handler):
 
     def _fire_connection_state_changed_event(self, status):
         if self._connection_state_handler:
-            asyncio.run_coroutine_threadsafe(
-                self._connection_state_handler(status),
-                loop = self._loop
+            self.hass.create_task(
+                self._connection_state_handler(status)
             )
 
 
@@ -105,9 +104,8 @@ def set_last_message_received_handler(self, handler):
 
     def _fire_last_message_received_event(self):
         if self._last_message_received_handler:
-            asyncio.run_coroutine_threadsafe(
-                self._last_message_received_handler( datetime.now(UTC).replace(tzinfo=pytz.UTC) ),
-                loop = self._loop
+            self.hass.create_task(
+                self._last_message_received_handler( datetime.now(UTC).replace(tzinfo=pytz.UTC) )
             )
 
 
@@ -118,9 +116,8 @@ def set_received_message_count_handler(self, handler):
     def _fire_received_message_count_event(self):
         self._received_message_count += 1
         if self._received_message_count_handler:
-            asyncio.run_coroutine_threadsafe(
+            self.hass.create_task(
                 self._received_message_count_handler( self._received_message_count ),
-                loop = self._loop
             )
 
     def process_messages(self, data=None):
@@ -293,10 +290,8 @@ def _callback_send_message_to_serial_bus(self, msg):
                 LOGGER.debug("[Gateway] [Id: %d] Send message: %s - Serialized: %s", self.dev_id, msg, msg.serialize().hex())
 
                 # put message on serial bus
-                # asyncio.ensure_future(self._bus.send(msg), loop=self._loop)
-                asyncio.run_coroutine_threadsafe(
-                    self._bus.send(msg), 
-                    loop = self._loop
+                self.hass.create_task(
+                    self._bus.send(msg)
                 )
         else:
             LOGGER.warn("[Gateway] [Id: %d] Serial port %s is not available!!! message (%s) was not sent.", self.dev_id, self.serial_path, msg)

diff --git a/tests/test_binary_sensor_GatewayConnectionState.py b/tests/test_binary_sensor_GatewayConnectionState.py
@@ -20,6 +20,7 @@ def test_GatewayConnectionState(self):
         gateway=GatewayMock()
         gateway._bus._is_active = False
         gateway.hass.async_create_task = lambda a: []
+        gateway.hass.create_task = lambda a: []
         bs = GatewayConnectionState(Platform.BINARY_SENSOR, gateway)
 
         bs.value_changed(True)
@@ -32,6 +33,7 @@ def test_directly_online_GatewayConnectionState(self):
         gateway=GatewayMock()
         gateway._bus._is_active = True
         gateway.hass.async_create_task = lambda a: []
+        gateway.hass.create_task = lambda a: []
         bs = GatewayConnectionState(Platform.BINARY_SENSOR, gateway)
 
         bs.value_changed(True)