Fix 905 - Add linebreaks to gabc output.

[eschwab]

Addresses #905

Ready for review.

[rpspringuel]

I strongly suspect that this breaks the gabc-gabc tests. Have you checked that?

✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝
Br. Samuel, OSB
(R. Padraic Springuel)
PAX ☧ ΧΡΙΣΤΟΣ

On Feb 13, 2016, at 12:29 PM, Br. Elijah Schwab, O.Carm [email protected] wrote:

Addresses #905

Ready for review.

You can view, comment on, or merge this pull request online at:

#916

Commit Summary

Fix #905: Add linebreaks to gabc output.
Update CHANGELOG for fixing #905.
File Changes

M CHANGELOG.md (1)
M src/gabc/gabc-write.c (26)
Patch Links:

https://github.com/gregorio-project/gregorio/pull/916.patch
https://github.com/gregorio-project/gregorio/pull/916.diff
—
Reply to this email directly or view it on GitHub.

[eschwab]

I have attempted to test that, and the gabc-gabc tests pass. I have not dug deep into it yet, since I expected at least one to fail.

[henryso]

You might be doing something wrong. On my system, pretty much all gabc-gabc tests (expectedly) fail under your branch.

[eschwab]

I can't figure out I am doing wrong. ./gregorio-test.sh gabc-gabc reports that all pass with a real time of .055s. Changing the option to gabc-output has the same result.

[henryso]

Did you install the new gregorio? If not, you need to use the -g argument to point at your build directory.

[eschwab]

Yes, the new gregorio is installed. $(which gregorio) -V gives the correct version.

[henryso]

Looking at your command again, ./gregorio-test.sh gabc-gabc will not run any tests. You should instead use ./gregorio-test.sh tests/gabc-gabc/**/*.gabc (in bash, you'll have to set the globstar shell option):

shopt -s globstar
./gregorio-test.sh tests/gabc-gabc/**/*.gabc

[eschwab]

Ok, I think I have it figured out now. There should be a PR to the test repo for this one.

[eroux]

Tests and code are ok for me to merge