fixes #891 #892
fixes #891 #892
Conversation
|
I've pushed a few changes |
|
I'm done with my review. |
| \t-v verbose mode\n\ | ||
| \t-W displays all warnings\n\ | ||
| printf(_("Usage: %s [OPTION]... [-s | INPUT_FILE]\n\ | ||
| \nEngrave Gregorian chant scores, convert a gabc file in GregorioTeX.\n\n\ |
There was a problem hiding this comment.
Ok, I just noticed this... "in" should be "to".
| \n")); | ||
| See <%s> for general documentation,\n\ | ||
| GregorioRef-%s.pdf and GregorioNabcRef-%s.pdf for full documentation.\ | ||
| \n"), PACKAGE_URL, VERSION, VERSION); |
There was a problem hiding this comment.
Since these are #define, they can be inserted directly: "...GregorioRef-" VERSION ".pdf..."
|
more comments addressed, please review |
|
Looks good to me. |
|
Do we have tests for this output? If not, should we? ✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝
|
|
All tests pass, I don't think it's necessary to have many tests for that... and even if some could be done, I think we should focus more on the features and bug requests for 4.1 (I have a big bug under Windows, but I didn't understand it enough yet). |
|
Shouldn't the short usage info message print the command syntax? I.e. What is the first line of the help message. ✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝
|
|
good idea, done |
|
We have tests for all the options, but they are pass/fail (return code) only and don't check the message content. |
|
I've transfered a few messages to stderr, and added a message for non-blocking case, please review, I think I'm done with changes (I thought I was for a few hours actually)... |
|
I think this is OK to merge. |
All tests pass. Please review my broken English