Fix for #70 and some porrectus episemus bugfixes #384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two commits primarily to address #70.
While testing, I noticed some weirdness with the heights of horizontal episemus decorating porrectus and torculus resupinus figures. See the following tests in gregorio-tests to see the difference:
I made some semi-educated decisions around positioning the episemus on the final two notes of a porrectus or torculus resupinus, which may be wrong, so please review these changes carefully before accepting them, and please let me know if I should change anything.
A few notes:
PunctumSmall
and left-aligned. This is the essential fix for New horizontal episemus on porrectus except last note #70. I did this so that thee calculations for what modern notation calls ledger lines will be correct.(d_h_g_j)
: the height of the episemus abovehg
is in a different place than the episemus aboved
. In the older code, the episema would be at same height, but actually end up below thei
note. I will look into this on another day unless someone beats me to it.