Added minimalinitialwidth dimension.

[henryso]

Fixes #1213.

Added a test for this new feature. No other tests change.

Please review and merge if satisfactory.

[eroux]

the style lines look a bit weird, what happens if you remove them?

[henryso]

I copied that from the manualinitialwidth code immediately below. I'm pretty sure it's there to handle relative dimensions like em since space@dimen macros are text. Therefore, I don't think the style lines should be removed.

[rpspringuel]

That is their purpose, but I think the need to be outside the conditional so that the comparison picks up the right font settings too.

✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝
Br. Samuel, OSB
(R. Padraic Springuel)
PAX ☧ ΧΡΙΣΤΟΣ

On Nov 8, 2016, at 12:01 PM, Henry So [email protected] wrote:

@henryso commented on this pull request.

In tex/gregoriotex-main.tex:

@@ -444,6 +444,11 @@
\gre@debugmsg{ifdim}{ manualinitialwidth = 0pt}%
\ifdim\gre@space@dimen@manualinitialwidth=0 pt\relax%
\global\gre@dimen@initialwidth=\wd\gre@box@initial %

•  \ifdim\gre@dimen@initialwidth<\gre@space@dimen@minimalinitialwidth\relax%
  

•    \gre@style@initial%
  

  I copied that from the manualinitialwidth code immediately below. I'm pretty sure it's there to handle relative dimensions like em since space@dimen macros are text. Therefore, I don't think the style lines should be removed.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[henryso]

Thanks for catching that. The review process is working! Fixed.

[eroux]

ok, I think we can merge