Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: double keys #755

Closed
eroux opened this issue Jan 6, 2016 · 5 comments
Closed

feature: double keys #755

eroux opened this issue Jan 6, 2016 · 5 comments
Assignees
@henryso
Labels
enhancement gabc syntax TeX

Comments

@eroux
Copy link
Contributor

eroux commented Jan 6, 2016

This is a feature that was asked by an abbey to ease transcription: it would be nice to be able to use two keys, stacked one on another. The syntax could be the same as "polyphony", for instance c4{c1}. Only the first specified key would be taken into account for the computations, the other one would just be typeset. It should also work for clef changes, and all new lines should contain both keys.
@henryso
Copy link
Contributor

henryso commented Jan 6, 2016

Would you want to offset the stack if the keys would overlap (i.e., c3 and c4)?

@eroux
Copy link
Contributor Author

eroux commented Jan 6, 2016

That would be perfect indeed!

@henryso
Copy link
Contributor

henryso commented Jan 6, 2016

Right now, curly braces for "polyphony" is implemented using TeX magic. This double-key feature needs something more carefully handled. I think adopting the @ between the clefs (in order to "fuse" the clefs) is more easily lex-ed. So your example would be c4@c1. What do you think?

@eroux
Copy link
Contributor Author

eroux commented Jan 7, 2016

Sure!

@henryso henryso self-assigned this Jan 7, 2016
henryso added a commit to henryso/gregorio that referenced this issue Jan 7, 2016
@henryso
Implemented the ability to add a secondary clef.
772d813 
Fixed bugs with flatted clefs on 5-line staves.
Fixes gregorio-project#755.
henryso added a commit to henryso/gregorio-test that referenced this issue Jan 7, 2016
@henryso
Updated tests/expectations for the fix for gregorio-project/gregorio#755
e2b37da 
.
henryso added a commit to henryso/gregorio that referenced this issue Jan 7, 2016
@henryso
Implemented the ability to add a secondary clef.
ff34d51 
Fixed bugs with flatted clefs on 5-line staves.
Fixes gregorio-project#755.
@henryso henryso mentioned this issue Jan 7, 2016
Merged
henryso added a commit to henryso/gregorio-test that referenced this issue Jan 7, 2016
@henryso
Updated tests/expectations for the fix for gregorio-project/gregorio#755
2f19ad3 
.
eroux added a commit to gregorio-project/gregorio-test that referenced this issue Jan 7, 2016
@eroux
Merge pull request #84 from henryso/fix-755
9496411 
Updated tests/expectations for the fix for gregorio-project/gregorio#755
@eroux eroux closed this as completed Jan 7, 2016
@eroux
Copy link
Contributor Author

eroux commented Jan 12, 2016

I just ran into some images on musicasacra:

two-clef-1
two-clef-2

(just for archives)

@eroux eroux mentioned this issue Feb 12, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henryso henryso

Labels
enhancement gabc syntax TeX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eroux @henryso