Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crunching space around alterations mid-line #663

Closed
rpspringuel opened this issue Oct 27, 2015 · 0 comments
Closed

Crunching space around alterations mid-line #663

rpspringuel opened this issue Oct 27, 2015 · 0 comments
Labels
enhancement TeX
Milestone
4.0

Comments

@rpspringuel
Copy link
Contributor

Much like alterations which lead a line, it should be possible for alterations which lead a syllable mid-line to invade the space of the previous syllable so long as a few conditions are met:

  1. The alteration extends out to the left of the lyrics of its own syllable (i.e. the syllable has a positive begindifference)
  2. The previous syllable had lyrics which extended beyond the end of its notes (i.e. previousendifference is positive)
  3. The space between the notes of the previous syllable and the alteration is at least spacebeforealteration.
@rpspringuel rpspringuel added this to the 4.1 milestone Oct 27, 2015
eroux added a commit that referenced this issue Dec 3, 2015
@eroux
(failed) attempt to fix #663
7759978 
* include alterationspace in the computation of nextnotesaligncenter
* make alterationspace a dimen (as it is involved in the computation of nextbegindifference, which should be a dimen, but that's for another time)
@eroux eroux mentioned this issue Dec 3, 2015
Merged
eroux added a commit that referenced this issue Dec 3, 2015
@eroux
(failed) attempt to fix #663
10801f9 
* include alterationspace in the computation of nextnotesaligncenter
* make alterationspace a dimen (as it is involved in the computation of nextbegindifference, which should be a dimen, but that's for another time)
rpspringuel added a commit that referenced this issue Dec 4, 2015
@rpspringuel
Merge pull request #688 from gregorio-project/fix-663
86b2a18 
attempt to fix #663
@henryso henryso modified the milestones: 4.0, 4.1 Dec 4, 2015
@henryso henryso closed this as completed Dec 4, 2015
rpspringuel added a commit to rpspringuel/gregorio that referenced this issue Dec 9, 2015
@rpspringuel
Merge branch 'release-4.0' into develop
7c52222 
* release-4.0:
  Adding Known Bugs to CHANGELOG
  Making Release
  Called gregorio_strdup instead of strdup.
  Applied fixes suggested by Karl Berry for integration into TeX Live.
  Fixed incorrect detection of note-in-same-glyph for episema height adjustment. Fixes gregorio-project#693.
  Spelling error in CHANGELOG
  Typo in example
  doc: dimen -> dimension
  Switching from numerical to keyword argument
  document alterationspace change
  fix alterationspace and beforealterationspace value in doc
  remove spurious spaces in Command_Index_User
  remove useless line
  (failed) attempt to fix gregorio-project#663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement TeX
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
2 participants
@henryso @rpspringuel