problem updating \gre@stafflinefactor

[asbloomf]

This was happening on 5.2.1

If \greconffactor is different than what the staff size is set to, it seems to cause a problem when loading the new space file. It multiplies by the staff size but divides by \greconffactor. Anyway I think that is what was going on. So if you have the staff size set to something big like 23 and the regular \greconffactor of 17, when you load the new spacing, \gre@stafflinefactor gets set to 31 (23 * 23 / 17). It's easy to workaround so it's not a big deal. I'm not sure if anything else is affected, but the line thickness was certainly quite noticeable.

[rpspringuel]

It sounds like expected behavior. Your new spacing file should have its own \greconffactor. This variable indicates what size staff the gsp file assumes so that the distances loaded by the file can be scaled appropriately if a different staff size is currently in effect. This prevents odd order effects in changing staff size and loading custom spaces.

Example: I have a project for which I expect to print staves at 20. In designing a custom gsp file for the project I set \greconffactor to 20 so that I can enter custom spaces directly based on page measurements without any math for scaling. Later on, I create another project in which I want to include a scaled down version of one of the scores in the first project, say at size 10 (half scale). Because of \greconffactor, I can load my custom gsp file either before or after switching to size 10, and I never have to switch to size 20 (if that isn’t used elsewhere in the new project).

_{Sent with GitHawk}

[asbloomf]

It didn't seem like expected behavior, but maybe it is. What confused me was that I got different behavior when I changed the order of \grechangestaffsize{17} and \greloadspaceconf{default} when switching back. It seemed to me that loading the spacing configuration wouldn't be dependent on what the staff size was set to but then it was. Anyway, like I said, now that I understand how it works it's not a big deal.

[rpspringuel]

Order effects are exactly what \greconffactor was implemented to avoid. If you saw one, then there's a bug to be worked out. Can you post a MWE which shows the order effect?

[asbloomf]

I think this shows it. I set the staff size and then each time I load the default spacing, it makes the lines a little thicker.
mwe.pdf
mwe.tex.txt

[rpspringuel]

That's definitely a bug. I'm in the midst of exams, and have my pre-ordination retreat next week, but I'll put this on the to-do list.

[rpspringuel]

Fix is up (#1464). Please test and indicate if it is acceptable.

[asbloomf]

Yes, this fixes the problem.

…

On Tue, 21 May 2019 at 14:16, Br. Samuel Springuel ***@***.***> wrote: Fix is up (#1464 <#1464>). Please test and indicate if it is acceptable. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1461?email_source=notifications&email_token=AAYRQXIZ7NP2JQ4BWCTBXNLPWQ36XA5CNFSM4HLA6LUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV4XY2Y#issuecomment-494500971>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYRQXJXQMZGHOX342S7OF3PWQ36XANCNFSM4HLA6LUA> .