-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
possibility to have style markups cross syllables #1121
Comments
About average difficulty. |
I think backwards compatibility may be a concern here. Because of the way it currently works, I'm willing to bet there are gabc files in the wild which depend on the fact that an opened style is automatically closed at the end of the syllable. |
correct... Well, I'm not entirely sure what's best... I tend to like the behavior described here, maybe we could just switch to it with a big red warning in the changelog? |
It would be possible to toggle the behavior with a gabc header, so that's worth consideration (though it does add complexity). In the back of my mind is also the future "protrusion" tag, which really must be closed at the end of a syllable (and really nowhere else) and the future "clear" tag which really is a syllable modifier more than a styling toggle. Add that to Whatever we decide for the toggle, I think it makes sense to allow styles to span syllables as well; this parallels the |
I'm not really sure what you're suggesting for protrusion and clear? |
All I want to say is that I'd appreciate this feature a lot, |
For this you could just redefine the main style to be small caps, that would be more readable... But maybe that would be the best solution to our problem? It could be just a small verbatim... For the ae' small caps, it indeed doesn't exist in Junicode. It's actually quite rare, Linux Libertine doesn't have it neither. ArnoPro does. |
Well, it is just a single stanza in the whole hymn that should be in small caps, everything else in the hymn is meant to be written normally (this is just to stress that on this stanza people should be kneeing). |
Ok, but you could set the default style to small caps at the beginning of the stanza, and reset it to normal after... |
@eroux I'm suggesting that we use a different syntax for protrusion and clear. |
Thinking about it for a bit, perhaps something like |
Looking at this in more detail, not closing the style tag in the syllable is very likely to generate a syntax error when running gregorio, so backwards compatibility is not an issue. The exception is when you have a close to match every open, but they are of different types. For example:
I think it's fairly safe to just add this feature without worrying about backwards compatibility. What do you think? |
Looks ok to me! Also, why do you think |
XML and typical use of HTML/SGML leave you with the idea that you need to "close" the open tag. |
In that case we might want to use |
I see... why not |
If that's the consensus, then I will acquiesce. |
I'd rather error out on closing |
I'm with @henryso on this one and would favor a separate syntax for tags which don't need to be closed. I find
I also think this needs to be fixed so that open tags look only for a matching close. |
Question about this issue specifically. If you open a style twice, do you want to require closing it twice before the style goes away? For example, with Note: If you try this in the current code, you have to do something incorrect in order to balance opens with closes, so I don't think the current behavior needs to be considered to answer this question. @rpspringuel I will take care of the "correct" close problem as part of this issue, now that I'm aware of it. |
I would label opening a style which is already open a syntax error. Once a style is open, it should be closed before it can be opened again. |
I think it can be ignored... or it can raise an error, why not |
It used to work like that but it has been removed (I thought it was safer not to do it), but it would be helpful for some projects to be able to do things such as
how hard would it be to make this feature come back?
The text was updated successfully, but these errors were encountered: