Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

900_gregorio.xml should not use the luainputenc package #1087

Closed
henryso opened this issue May 5, 2016 · 3 comments
Closed

900_gregorio.xml should not use the luainputenc package #1087

henryso opened this issue May 5, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@henryso
Copy link
Contributor

henryso commented May 5, 2016

This means removing \usepackage[utf8]{luainputenc}, which actually breaks the new gregorio, causing it to emit oe? ae? above the score. Is there a way to check for this package and not generate the special character commands that cause problems with it, or is there a better way to encode things so that luainputenc doesn't break gregorio?

Should we also switch from times to libertine, which would also remove \usepackage[T1]{fontenc}?

(This bug was reported directly to me by Gerry Davila).

@henryso henryso added the bug label May 5, 2016
@henryso henryso added this to the 4.2 milestone May 5, 2016
@rpspringuel
Copy link
Contributor

Looking at the file, it appears that the use of luainputenc is for setting a default font which is "reasonable". I guess the question then is what's the definition of "reasonable?" If we simply picking a font that doesn't look out of place in a chant score, then I'd be inclined to switch to libertine in order to make things as simple as possible.

However, given the use of Times, I suspect that "reasonable" was originally defined as matching the default font that scribus uses for the rest of the document. If that is the case, and we want to preserve that, then I'm not sure what the best way to go is.

As for testing if a package is loaded see here.

@henryso
Copy link
Contributor Author

henryso commented May 6, 2016

I think the original intent was to translate the things in main-lualatex.tex for use with Scribus. If you recall, the old main-lualatex.tex had these exact settings: [utf-8]{luainputenc}, [T1]{fontenc}, and {times}. Nowadays, you typically want to use a Unicode font, so my opinion is (if you couldn't tell) to just switch to {libertine}. Perhaps @eroux has an opinion.

On the package testing front, is there equivalent when not using LaTeX? Perhaps we use the "safer" set of special characters if the user is not using LaTeX?

@eroux
Copy link
Contributor

eroux commented May 6, 2016

no inputenc, no fontenc, but fontspec and libertine would be best indeed. I don't think we have to change anything for non-LaTeX users, they usually know what they're doing and can debug easily

@henryso henryso removed the question label May 7, 2016
henryso added a commit to henryso/gregorio that referenced this issue May 8, 2016
Quashed special characters that emit spurious text under luainputenc.
Fixes gregorio-project#1087.
henryso added a commit to henryso/gregorio that referenced this issue May 8, 2016
Quashed special characters that emit spurious text under luainputenc.
Fixes gregorio-project#1087.
@henryso henryso self-assigned this May 8, 2016
eroux added a commit that referenced this issue May 10, 2016
@eroux eroux closed this as completed May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants