Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table name not escaped on join #888

Closed
sl33tz0r opened this issue Jul 31, 2018 · 2 comments
Closed

Table name not escaped on join #888

sl33tz0r opened this issue Jul 31, 2018 · 2 comments
Labels
Bug
Milestone
3.3.0

Comments

@sl33tz0r
Copy link

that's ok most of the time, but if table name is order (or any other sql keyword), the generated sql is not valid
greenrobot-team added a commit that referenced this issue Aug 21, 2018
@greenrobot-team
QueryBuilder: escape table name for JOIN as well.
b4c20d1 
#888
@greenrobot-team
Copy link
Collaborator

Thanks for reporting! -ut

@greenrobot-team greenrobot-team added this to the 3.x milestone Aug 21, 2018
@greenrobot-team greenrobot-team modified the milestones: 3.x, 3.3.0 Feb 18, 2020
@greenrobot-team
Copy link
Collaborator

3.3.0 has been released which should fix this issue.
https://greenrobot.org/greendao/changelog/

diamondyhand added a commit to diamondyhand/green-DAO that referenced this issue Dec 15, 2023
@diamondyhand
QueryBuilder: escape table name for JOIN as well.
8bb7232 
Closes greenrobot/greenDAO#888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
2 participants
@sl33tz0r @greenrobot-team