Add internationalization support with chrome.i18n + English language #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mariospr Thanks so much for the contribution. Good thing done! |
|
@mariospr gah! for some reason i never actually merged this PR when i closed it. have just gone through the merge process now. thanks again for doing this! |
|
Haha. No problem, glad to see it's useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds support for translating this (great) extension using the chrome.i18n API described in https://developer.chrome.com/extensions/i18n, providing a
messajes.jsonfile for English as a start.Note that chrome.i18n does not support translating HTML files (only CSS and .js/.json ones, see upstream bug), so people do all sorts of creative things to work around this issue. For this particular case, I went ahead with the solution proposed in this thread of StackOverflow which I hope will be good enough considering that loading the extension's specific web pages is not something that will happen very often (and even if it does, those are small enough pages).
Please let me know what you think, and whether you'd be happy or not to integrate this branch, as well as whether there's anything you'd like me to change before merging it (in case you want to do it so).