Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command-a in url box is mistaken for control-a, and opens all the sleeping tabs in a window #847

Open
jpbianchi opened this issue Jan 31, 2019 · 6 comments

Comments

@jpbianchi
Copy link

jpbianchi commented Jan 31, 2019

Please complete the following information when submitting a feature request or bug report.

  • Extension version: v7.0.109
  • Browser name & version: Chrome 71.0.3578.98
  • Operating system & version: OSX 10.13.6

It's been some time now that, when I want to select a whole url by clicking in the url box and do the usual command-a, Chrome does not, as it should, select the text at all but unfreezes all the frozen tabs in that window, as if I had typed control-a (which is my setting to do that).
It's as if the extension confuses command and control when the cursor is in the url box.
This is new, I never had this problem for a long time so I don't know what changed.
It's not a huge problem, very annoying, and when chrome re-opens 60 sleeping pages at once, my 12 cores get used up to 85% for quite some time. If I type ctrl-s to freeze all the tabs to try to stop the problem, nothing happens, the extension continues re-opening all the tabs.
So far, this happens only when the cursor is in the url box. When I do command-a everywhere else, the problem does not happen.

@deanoemcke
Copy link
Collaborator

deanoemcke commented Feb 3, 2019

@jpbianchi I can reproduce this. It's a strange bug. Unfortunately, the handling of hotkeys is outside of my control. All I receive within the extension is a message to say that that particular hotkey action was triggered (incorrectly in this case).
Possibly related to this chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=890418

I know it's a pain, but perhaps your best option is to change the keyboard shortcuts you're using?
And submitting a bug report to the chromium team is probably a good idea too.

@jpbianchi
Copy link
Author

jpbianchi commented Feb 4, 2019 via email

@deanoemcke
Copy link
Collaborator

@jpbianchi For the CPU load issue. It sounds like this is happening when you accidentally unsuspend all your tabs? If this is the case, it's really a chrome issue, there's not much I can do about it unfortunately (the CPU load I mean).

I'll investigate whether I can somehow interrupt the tab loading and force the tabs to suspend quickly.

@jpbianchi
Copy link
Author

jpbianchi commented Feb 5, 2019 via email

@deanoemcke
Copy link
Collaborator

I have just committed a change that allows tabs to be suspended even during loading. This should help somewhat when trying to stop all your tabs from reloading (v7.0.165).

It seems that you are also suggesting that I stagger the unsuspending process when unsuspending a large number of tabs at the same time? This is a little off topic for this issue. Would you mind creating a new issue for this (as a feature request)?

Thanks!

@jpbianchi
Copy link
Author

jpbianchi commented Feb 5, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants