Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs that fails to capture a screenshot #677

Open
deanoemcke opened this issue Apr 17, 2018 · 7 comments
Open

Tabs that fails to capture a screenshot #677

deanoemcke opened this issue Apr 17, 2018 · 7 comments

Comments

@deanoemcke
Copy link
Collaborator

deanoemcke commented Apr 17, 2018

This is a placeholder for listing urls that have issues when being screen captured.
Please note that in the current webstore release (v6.30) this can cause the tab to fail to suspend altogether (if the screen capturing option is enabled). This has been fixed in the upcoming release, and in future, if a screen capture attempt fails, the tab will still suspend, but without the screen capture.

@deanoemcke
Copy link
Collaborator Author

deanoemcke commented Apr 17, 2018

Tainted canvas error (#657 - currently unresolved):
Failed to execute 'toDataURL' on 'HTMLCanvasElement': Tainted canvases may not be exported.
http://en.miui.com/forum.php
https://p2power.co.nz/

Tabs with large number of dom elements (#554 - new behaviour in upcoming release):
http://giveawaylisting.com/

Tabs take exponentially longer to suspend if page is not at normal zoom (#503 - Fixed in new release):
http://www.illinoiscourts.gov/SupremeCourt/Rules/Art_III/ArtIII.htm

Long tabs dont capture entire page (#533 - wontfix. this is due to practical limitations):
http://www.illinoiscourts.gov/SupremeCourt/Rules/Art_III/ArtIII.htm
https://www.bloomberg.com/features/2017-the-ether-thief/

Badly formatted/squashed text (#653 - fix in upcoming release):
http://tampermonkey.net/scripts.php?ext=dhdg&show=dhdg

Image missing/not captured properly (currently unresolved - due to html2canvas limitations/issues):
http://derkatalog.surge.sh/detail/1517714113483
https://www.theverge.com/2017/6/2/15722112/best-finance-apps-money-budget-clarity-credit-karma-digit-venmo

Badly captured page:
https://productforums.google.com/forum/#!topicsearchin/chrome/thegreatsuspender

@KlausEverWalkingDev
Copy link

@deanoemcke, you could try to mimic what the Tab Suspender extension (https://chrome.google.com/webstore/detail/tab-suspender/fiabciakcmgepblmdkmemdbbkilneeeh) does about screenshots. It captures the page as it really it is.

@hanvari
Copy link

hanvari commented Jul 17, 2018

For Amazon website (I use www.amazon.ca), none of the images in the page are captured. It only captures text and page structure, images are blank.

On a side note, there are mature open-source extensions available for taking screenshots in chrome. I was just thinking why not taking benefit of those extensions for the taking screen-captures to be used by thegreatsuspender?

@deanoemcke
Copy link
Collaborator Author

@hanvari due to security restrictions it is impossible to capture the contents of images that have a source origin different to the hosted webpage. there is nothing i can do about this.

as for existing extensions that take screenshots in chrome, you will find that they require the tab you want to screen capture to be currently visible. this does not help for this extension as i need to be able to capture the contents of tabs that are in the background.

in this issue: #503 @Pascal666 suggests a lot of alternative js libraries for handling screen capture. i went through them all and determined they are all either unsuitable, or do not do as good a job as the current library (html2canvas).

that said, i did this check a while ago, and it looks like the dom-to-image library might solve at least one issue that html2canvas still struggles with: #657

perhaps I'll take another look.

@deanoemcke
Copy link
Collaborator Author

@claudenirrj i'll take another look at the Tab Suspender extension. Last time I looked it was using the same library as this one. but perhaps they've found a better alternative.

@deanoemcke
Copy link
Collaborator Author

I have added support for the dom-to-image screencapture library. Although it appears to be much slower, and also less reliable than html2canvas.
You can switch to the dom-to-image library by going to the extension debug.html page (chrome-extension:///debug.html) and toggling the "useAlternateScreenCaptureLib" option.

@deanoemcke
Copy link
Collaborator Author

It seems now that any youtube tab will fail to capture a screenshot (with html2canvas). The library returns a valid dataURL but the contents of it are blank.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants