-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable/Uninstalling destroys open suspended tabs #216
Comments
@terado I completely agree with your desired / expected behaviour. And you are correct that there is no disable / uninstall hook available. I have thought about including a warning message on extension install and may still do this. But I feel that the chances of this information being properly digested and actually remembered / acted upon when the user goes to uninstall is slim. There is already a button to unsuspend all tabs, but once again, there is no way to direct the user to this button at the relevant time (when they go to uninstall). The fact that the suspended pages are tied to the extension process is unavoidable for now. There ARE local files that get served, but the still belong to the extension process - there is no getting around this. The extension runs in a sandbox, and any functionality it provides is revoked when the extension is uninstalled. |
If you are suffering from this, this little bookmarklet may help...
|
@joeytwiddle perhaps you would like to share your bookmarklet on the issue below? I suspect it will need a little tweaking. As it uses uri now instead of url.. Please refer to this guide on why this happens and how to recover lost tabs: #526 |
Update IssueAssignment.yml
When uninstalling extension the open tabs that have been suspended are then destroyed. When disabling extension they are closed until re-enabling.
Ideally one would expect the open tabs to be restored as open and un-suspended.
Suggestions
If no hook is accessible during disable/uninstall perhaps these suggestions are available:
The text was updated successfully, but these errors were encountered: