Fix for missing donate buttons (#827)

greatsuspender · Dec 19, 2018 · f4f87af · f4f87af
1 parent c7a196f
commit f4f87af
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/src/js/about.js b/src/js/about.js
@@ -14,8 +14,8 @@
     gsAnalytics.reportEvent('Donations', 'HidePopupManual', hideNag);
   }
 
-  function loadDonateButtons() {
-    document.getElementById('donateButtons').innerHTML = this.responseText;
+  function loadDonateButtons(responseText) {
+    document.getElementById('donateButtons').innerHTML = responseText;
 
     var bitcoinBtn = document.getElementById('bitcoinBtn');
     var patreonBtn = document.getElementById('patreonBtn');
@@ -55,7 +55,7 @@
     }
 
     var request = new XMLHttpRequest();
-    request.onload = loadDonateButtons;
+    request.onload = () => loadDonateButtons(request.responseText);
     request.open('GET', 'support.html', true);
     request.send();
 

diff --git a/src/js/gsSuspendedTab.js b/src/js/gsSuspendedTab.js
@@ -5,7 +5,10 @@ var gsSuspendedTab = (function() {
 
   async function initTab(tab, tabView) {
     if (!tabView) {
-      gsUtils.warning(tab.id, 'Could not get internalTabView for suspended tab');
+      gsUtils.warning(
+        tab.id,
+        'Could not get internalTabView for suspended tab'
+      );
     }
 
     gsUtils.localiseHtml(tabView.document);
@@ -404,7 +407,7 @@ var gsSuspendedTab = (function() {
 
     const request = new XMLHttpRequest();
     request.onload = () => {
-      loadDonateButtonsHtml(_document);
+      loadDonateButtonsHtml(_document, request.responseText);
     };
     request.open('GET', 'support.html', true);
     request.send();
@@ -413,8 +416,8 @@ var gsSuspendedTab = (function() {
     _document.getElementById('donateBubble').classList.add('fadeIn');
   }
 
-  function loadDonateButtonsHtml(_document) {
-    _document.getElementById('donateButtons').innerHTML = this.responseText;
+  function loadDonateButtonsHtml(_document, responseText) {
+    _document.getElementById('donateButtons').innerHTML = responseText;
     _document.getElementById('bitcoinBtn').innerHTML = chrome.i18n.getMessage(
       'js_donate_bitcoin'
     );