Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all): use functions for providing configs #3283

Merged

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #3279

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

SEARCH_FEDERATED_CONFIG_DEFAULT -> DAFF_SEARCH_FEDERATED_CONFIG_DEFAULT, SEARCH_FEDERATED_CONFIG_TOKEN -> DAFF_SEARCH_FEDERATED_CONFIG_TOKEN

Other information

BREAKING CHANGE: `SEARCH_FEDERATED_CONFIG_DEFAULT` -> `DAFF_SEARCH_FEDERATED_CONFIG_DEFAULT`, `SEARCH_FEDERATED_CONFIG_TOKEN` -> `DAFF_SEARCH_FEDERATED_CONFIG_TOKEN`
@griest024 griest024 added the 🚨 breaking changes This PR or issue will cause a breaking change label Oct 16, 2024
@griest024 griest024 self-assigned this Oct 16, 2024
@griest024 griest024 requested a review from a team as a code owner October 16, 2024 16:01
@griest024 griest024 merged commit 4c3c9f1 into graycoreio:develop Oct 16, 2024
31 checks passed
@gray-bot gray-bot mentioned this pull request Oct 16, 2024
@griest024 griest024 deleted the feat/all/config-provider-functions branch October 16, 2024 16:15
gracetxgao pushed a commit to gracetxgao/daffodil that referenced this pull request Oct 24, 2024
BREAKING CHANGE: `SEARCH_FEDERATED_CONFIG_DEFAULT` -> `DAFF_SEARCH_FEDERATED_CONFIG_DEFAULT`, `SEARCH_FEDERATED_CONFIG_TOKEN` -> `DAFF_SEARCH_FEDERATED_CONFIG_TOKEN`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 breaking changes This PR or issue will cause a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configs
1 participant