Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daffio): render nav links from route data #3013

Merged

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The headers and sidebars that differ only by nav links are rendered with separate components.

What is the new behavior?

A single component is used to render the header and nav sidebar. Nav link data is provided in route config.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added package: daff.io @daffodil/daff.io status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin labels Aug 21, 2024
@griest024 griest024 self-assigned this Aug 21, 2024
@griest024 griest024 requested review from a team as code owners August 21, 2024 19:06
@griest024 griest024 changed the title feat(daffio): render nav lists from route data feat(daffio): render nav links from route data Aug 21, 2024
@griest024 griest024 force-pushed the feat/daffio/render-nav-lists-from-route branch from 6b844f5 to 882e5af Compare August 22, 2024 21:55
@griest024 griest024 merged commit d2567fa into graycoreio:develop Aug 22, 2024
8 checks passed
@gray-bot gray-bot mentioned this pull request Aug 22, 2024
@griest024 griest024 deleted the feat/daffio/render-nav-lists-from-route branch August 22, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: daff.io @daffodil/daff.io status: awaiting merge This PR has met all the requirements for merge and is waiting on an admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant