Fix TS types #284
Merged
Fix TS types #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrearden
commented
Jul 15, 2020
| @@ -78,6 +78,6 @@ export function cursorForObjectInConnection<T>( | |||
| * otherwise it will be the default. | |||
| */ | |||
| export function getOffsetWithDefault( | |||
| cursor?: ConnectionCursor | null, | |||
| cursor: ConnectionCursor | null | undefined, | |||
There was a problem hiding this comment.
TS complains because cursor is optional but the next parameter is not, so I just removed the optional and added undefined to the union. I also synced this on the Flow side.
IvanGoncharov
added
the
PR: bug fix 🐞
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
=======================================
Coverage 99.49% 99.49%
=======================================
Files 19 19
Lines 595 595
Branches 38 38
=======================================
Hits 592 592
Misses 3 3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.