chore(dependencies): use prettier as a dev dependency #223
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Looks like I messed up in 84ed000. Thanks for fixing! |
|
Could this be packaged into a new release please? It's annoying when serverless packages extra 15 MB for no good reason :) |
|
Hi @kassens. Is it possible to cut a release with this fix? It requires me to add yarn resolutions otherwise yarn use wrong version in node_modules/.bin. |
|
Bump for a fix too please. The resolutions seem to be buggy and when adding a new dep reverts to prettier 1 :(. |
|
@cliedeman I always run |
|
@TrySound thanks. That definitetly fixes it. Its just confusing and easy to forget. It only seems to happen in conjuction with yarn workspaces |
|
Friendly ping @kassens |
|
Would we provide a patch version on this change? My Lambda function is using this package and the |
|
@IvanGoncharov, maybe you can help get a new version published with this change? 🙇 |
This is actually breaking my test CI and probably not only mine.
I am not really sure how it ended up there since @kassens' PR was adding correctly.
Hope I haven't missed anything important but the test are passing 😄
would you consider patching the npm version ?