enable promise/param-names

graphql · Dec 13, 2022 · c6e1fa2 · c6e1fa2
1 parent be839df
commit c6e1fa2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.eslintrc.yml b/.eslintrc.yml
@@ -194,7 +194,7 @@ rules:
   promise/no-promise-in-callback: off
   promise/no-return-in-finally: error
   promise/no-return-wrap: error
-  promise/param-names: off
+  promise/param-names: error
   promise/prefer-await-to-callbacks: off
   promise/prefer-await-to-then: error
   promise/valid-params: error

diff --git a/src/execution/__tests__/executor-test.ts b/src/execution/__tests__/executor-test.ts
@@ -419,7 +419,7 @@ describe('Execute: Handles basic execution tasks', () => {
         return new Promise((resolve) => resolve('async'));
       },
       asyncReject() {
-        return new Promise((_, reject) =>
+        return new Promise((_resolve, reject) =>
           reject(new Error('Error getting asyncReject')),
         );
       },

diff --git a/src/execution/flattenAsyncIterable.ts b/src/execution/flattenAsyncIterable.ts
@@ -38,8 +38,8 @@ export function flattenAsyncIterable<T>(
         }
         // Nobody else is getting it. We should!
         let resolve: () => void;
-        waitForCurrentNestedIterator = new Promise<void>((r) => {
-          resolve = r;
+        waitForCurrentNestedIterator = new Promise<void>((_resolve) => {
+          resolve = _resolve;
         });
         const topIteratorResult = await topIterator.next();
         if (topIteratorResult.done) {