Skip to content

Commit

Permalink
enable promise/param-names
Browse files Browse the repository at this point in the history
  • Loading branch information
yaacovCR committed Dec 13, 2022
1 parent 8e8520b commit 660c90c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .eslintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ rules:
promise/no-promise-in-callback: off
promise/no-return-in-finally: error
promise/no-return-wrap: error
promise/param-names: off
promise/param-names: error
promise/prefer-await-to-callbacks: off
promise/prefer-await-to-then: error
promise/valid-params: error
Expand Down
2 changes: 1 addition & 1 deletion src/execution/__tests__/executor-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ describe('Execute: Handles basic execution tasks', () => {
return new Promise((resolve) => resolve('async'));
},
asyncReject() {
return new Promise((_, reject) =>
return new Promise((_resolve, reject) =>
reject(new Error('Error getting asyncReject')),
);
},
Expand Down
4 changes: 2 additions & 2 deletions src/execution/flattenAsyncIterable.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ export function flattenAsyncIterable<T>(
}
// Nobody else is getting it. We should!
let resolve: () => void;
waitForCurrentNestedIterator = new Promise<void>((r) => {
resolve = r;
waitForCurrentNestedIterator = new Promise<void>((_resolve) => {
resolve = _resolve;
});
const topIteratorResult = await topIterator.next();
if (topIteratorResult.done) {
Expand Down

0 comments on commit 660c90c

Please sign in to comment.