Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency node #5526

Merged
merged 1 commit into from
Sep 17, 2024
+10 −10
Merged

chore(deps): update dependency node #5526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22.6
22.9
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v22.6
22.9
2 changes: 1 addition & 1 deletion docker/cli.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:22.6.0-slim
FROM node:22.8.0-slim

RUN apt-get update && apt-get install -y ca-certificates

Expand Down
2 changes: 1 addition & 1 deletion docker/migrations.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:22.6.0-slim
FROM node:22.8.0-slim

RUN apt-get update && apt-get install -y ca-certificates

Expand All @@ -7,11 +7,11 @@
COPY --from=dist . /usr/src/app/
COPY --from=shared . /

ENV ENVIRONMENT production

Check warning on line 10 in docker/migrations.dockerfile

View workflow job for this annotation

GitHub Actions / build / build-and-dockerize

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV NODE_ENV production

Check warning on line 11 in docker/migrations.dockerfile

View workflow job for this annotation

GitHub Actions / build / build-and-dockerize

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV RELEASE $RELEASE

Check warning on line 12 in docker/migrations.dockerfile

View workflow job for this annotation

GitHub Actions / build / build-and-dockerize

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$RELEASE'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

Check warning on line 12 in docker/migrations.dockerfile

View workflow job for this annotation

GitHub Actions / build / build-and-dockerize

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

LABEL org.opencontainers.image.title=$IMAGE_TITLE

Check warning on line 14 in docker/migrations.dockerfile

View workflow job for this annotation

GitHub Actions / build / build-and-dockerize

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$IMAGE_TITLE'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
LABEL org.opencontainers.image.version=$RELEASE
LABEL org.opencontainers.image.description=$IMAGE_DESCRIPTION
LABEL org.opencontainers.image.authors="The Guild"
Expand Down
2 changes: 1 addition & 1 deletion docker/services.dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:22.6.0-slim
FROM node:22.8.0-slim

RUN apt-get update && apt-get install -y wget ca-certificates && rm -rf /var/lib/apt/lists/*

Expand All @@ -8,17 +8,17 @@
COPY --from=dist . /usr/src/app/$SERVICE_DIR_NAME/
COPY --from=shared . /

LABEL org.opencontainers.image.title=$IMAGE_TITLE

Check warning on line 11 in docker/services.dockerfile

View workflow job for this annotation

GitHub Actions / build / build-and-dockerize

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$IMAGE_TITLE'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
LABEL org.opencontainers.image.version=$RELEASE
LABEL org.opencontainers.image.description=$IMAGE_DESCRIPTION

Check warning on line 13 in docker/services.dockerfile

View workflow job for this annotation

GitHub Actions / build / build-and-dockerize

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$IMAGE_DESCRIPTION'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
LABEL org.opencontainers.image.authors="The Guild"
LABEL org.opencontainers.image.vendor="Kamil Kisiela"
LABEL org.opencontainers.image.url="https://github.com/kamilkisiela/graphql-hive"
LABEL org.opencontainers.image.source="https://github.com/kamilkisiela/graphql-hive"

ENV ENVIRONMENT production
ENV RELEASE $RELEASE

Check warning on line 20 in docker/services.dockerfile

View workflow job for this annotation

GitHub Actions / build / build-and-dockerize

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

Check warning on line 20 in docker/services.dockerfile

View workflow job for this annotation

GitHub Actions / build / build-and-dockerize

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$RELEASE'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
ENV PORT $PORT

Check warning on line 21 in docker/services.dockerfile

View workflow job for this annotation

GitHub Actions / build / build-and-dockerize

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

HEALTHCHECK --interval=5s \
--timeout=5s \
Expand Down
10 changes: 5 additions & 5 deletions integration-tests/docker-compose.integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ networks:

services:
local_cdn:
image: node:22.6.0-alpine3.20
image: node:22.8.0-alpine3.20
working_dir: /app
command: ['node', 'index.js']
networks:
Expand All @@ -38,7 +38,7 @@ services:
S3_BUCKET_NAME: artifacts

local_broker:
image: node:22.6.0-alpine3.20
image: node:22.8.0-alpine3.20
working_dir: /app
command: ['node', 'broker.js']
networks:
Expand Down Expand Up @@ -78,7 +78,7 @@ services:
SECRET: '${EXTERNAL_COMPOSITION_SECRET}'

external_composition:
image: node:22.6.0-alpine3.20
image: node:22.8.0-alpine3.20
working_dir: /app
command: ['node', 'example.mjs']
networks:
Expand Down Expand Up @@ -268,10 +268,10 @@ services:

# It's not part of integration tests
app:
image: node:22.6.0-alpine3.20
image: node:22.8.0-alpine3.20
command: ['npx', 'http-server']

# Redpand is used for integration tests, instead of Kafka. Zookeeper is no longer needed
zookeeper:
image: node:22.6.0-alpine3.20
image: node:22.8.0-alpine3.20
command: ['npx', 'http-server']
Loading