Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature : Polling blockHandler and intialization handler #4725

Merged
merged 24 commits into from
Aug 18, 2023
Merged

Feature : Polling blockHandler and intialization handler #4725

merged 24 commits into from
Aug 18, 2023

Conversation

incrypto32
Copy link
Member

@incrypto32 incrypto32 commented Jun 27, 2023 •
edited
Loading

Closes #959, #3221

@incrypto32 incrypto32 force-pushed the incrypto32/recurring-block-handlers branch 3 times, most recently from 5cf1a4a to 69ea6b0 Compare June 29, 2023 13:58
@incrypto32 incrypto32 changed the title Feature : Recurring blockHandler Feature : Polling blockHandler Jun 29, 2023
leoyvens
leoyvens reviewed Jul 10, 2023
View reviewed changes
chain/ethereum/src/data_source.rs Show resolved Hide resolved
chain/ethereum/src/trigger.rs Outdated Show resolved Hide resolved
@incrypto32 incrypto32 force-pushed the incrypto32/recurring-block-handlers branch 11 times, most recently from 5fec081 to bee8ab0 Compare July 17, 2023 18:42
@incrypto32 incrypto32 force-pushed the incrypto32/recurring-block-handlers branch 2 times, most recently from edf736d to 33a9feb Compare July 18, 2023 08:23
@incrypto32 incrypto32 force-pushed the incrypto32/recurring-block-handlers branch from a36f2b0 to 2448663 Compare July 19, 2023 10:49
@incrypto32 incrypto32 force-pushed the incrypto32/recurring-block-handlers branch from 2448663 to 8fa38ea Compare July 19, 2023 11:16
@incrypto32 incrypto32 requested a review from leoyvens July 19, 2023 11:23
@incrypto32 incrypto32 marked this pull request as ready for review July 20, 2023 04:01
@incrypto32 incrypto32 linked an issue Jul 20, 2023 that may be closed by this pull request
Initialization handlers #3221
Closed
@incrypto32 incrypto32 changed the title Feature : Polling blockHandler Feature : Polling blockHandler and intialization handler Jul 20, 2023
@incrypto32 incrypto32 self-assigned this Jul 20, 2023
leoyvens
leoyvens requested changes Jul 26, 2023
View reviewed changes
chain/ethereum/src/adapter.rs Outdated Show resolved Hide resolved
chain/ethereum/src/adapter.rs Outdated Show resolved Hide resolved
chain/ethereum/src/data_source.rs Show resolved Hide resolved
chain/ethereum/src/data_source.rs Outdated Show resolved Hide resolved
chain/ethereum/src/data_source.rs Outdated Show resolved Hide resolved
chain/ethereum/src/ethereum_adapter.rs Show resolved Hide resolved
@incrypto32 incrypto32 requested a review from leoyvens August 1, 2023 14:27
@incrypto32
Copy link
Member Author

I ran this on the integration cluster over the weekend, and No POI differences were found

@incrypto32
chain/ethereum, store/test-store : Add support for polling block hand…
22bf952 
…lers
@incrypto32
tests: Add tests for polling block_handler
f4618ce
@incrypto32
chain,tests : Add wildcard block filters for handling subgraphs with …
50548fc 
…static_filters
@incrypto32
tests : Add integration test for polling block_handlers in templates
fcd4e4d
@incrypto32
chain/ethereum: implement extend for wildcard block filters
33015b8
@incrypto32
chain, tests: remove EthereumBlockTriggerType::Polling and replace …
e706048 
…with `EthereumBlockTriggerType::Every`, add more constraints for block_handler count
@incrypto32
graph,chain,tests : add min_spec_version to datasource and validate it
f5ad2b7
@incrypto32
chain, tests: Add support for intialization handlers
24d3e73
@incrypto32
chain, tests: Add support for initialization handlers
bc15eb5
@incrypto32
chain/ethereum : handle conflicts when extending polling_intervals fo…
decbc4a 
…r block filters and add tests
@incrypto32
chain/ethereum : handle initialization triggers in `blocks_with_trigg…
4e31798 
…ers`
@incrypto32
tests/integration_tests/block_handlers: Test intialization handler ru…
e357fa4 
…ns first before any other handlers
@incrypto32
chain/ethereum: minor refactoring in ethereum_adapter.rs
1a3b3d4
@incrypto32
chain/ethereum, graph : minor refactoring for polling and once block …
4947864 
…handlers
@incrypto32
chain/ethereum : Add two new EthereumBlockTriggerType: Start and …
5d0154c 
…`End` replacing `Every`
@incrypto32
chain/ethreum : remove wildcard block filters
7800f39
@incrypto32
tests/integration-tests : Add test for non-filtered block-handler
c1355ee
@incrypto32
store/test-store: Add manifest tests for polling and once handlers
1daec0a
@incrypto32
chain/ethereum: remove address from BlockHandlerFilter::polling_inter…
543271d 
…vals
@incrypto32
chian, store, tests : Remove Address from polling_intervals filter
379d1e5
@incrypto32
chain/ethereum: Wire new EthereumBlockTriggerType::Start and Ethereum…
2ae5fde 
…BlockTriggerType::End, and consider BlockFilter when ordering
@incrypto32
chain/ethereum : wire EthereumBlockTriggerType::Start in `parse_tri…
fea4a5f 
…gger_blocks`
@incrypto32
chain/ethereum : refactor extend for BlockFilter
b9c8e97
@incrypto32 incrypto32 force-pushed the incrypto32/recurring-block-handlers branch from 106b812 to b9c8e97 Compare August 17, 2023 16:27
@incrypto32
Copy link
Member Author

Rebased with master

@incrypto32 incrypto32 merged commit cc7694f into master Aug 18, 2023
@incrypto32 incrypto32 deleted the incrypto32/recurring-block-handlers branch August 18, 2023 15:07
@incrypto32 incrypto32 mentioned this pull request Nov 8, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maoueh maoueh maoueh left review comments

@leoyvens leoyvens leoyvens approved these changes

Assignees

@incrypto32 incrypto32

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initialization handlers Add a polling block handler
3 participants
@incrypto32 @maoueh @leoyvens