Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jitter to ExponentialBackoff #4476

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Add jitter to ExponentialBackoff #4476

merged 2 commits into from
Mar 20, 2023

Conversation

YaroShkvorets
Copy link
Contributor

Implements #4474

Used by SubgraphRunner with default value = 0.2

@YaroShkvorets YaroShkvorets marked this pull request as ready for review March 20, 2023 13:48
@YaroShkvorets YaroShkvorets mentioned this pull request Mar 20, 2023
Closed
@leoyvens leoyvens self-requested a review March 20, 2023 15:45
@leoyvens
Copy link
Collaborator

Thanks! Lets also increase the default for GRAPH_SUBGRAPH_ERROR_RETRY_CEIL_SECS from 30 mins to 60 mins.

@YaroShkvorets
Copy link
Contributor Author

Thanks! Lets also increase the default for GRAPH_SUBGRAPH_ERROR_RETRY_CEIL_SECS from 30 mins to 60 mins.

Done

@leoyvens leoyvens merged commit 094e40b into graphprotocol:master Mar 20, 2023
@YaroShkvorets YaroShkvorets deleted the yaro/backof_jitter branch March 20, 2023 19:11
gusinacio pushed a commit to gusinacio/graph-node that referenced this pull request Mar 21, 2023
@YaroShkvorets @gusinacio
Add jitter to ExponentialBackoff (graphprotocol#4476)
580785b 
* add backoff jitter, tests and env variable

* increase default ERROR_RETRY_CEIL to 60 minutes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoyvens leoyvens leoyvens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YaroShkvorets @leoyvens