graphql: Allow gt/lt comparisons with Bytes fields
#4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutter
force-pushed
the
lutter/bytes-cmp
branch
from
e636669 to
4bf21f3
Compare
saihaj
approved these changes
Jan 6, 2023
lutter
force-pushed
the
lutter/bytes-cmp
branch
from
4bf21f3 to
6c5fafa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
Bytesfields, it was not possible to use less than/greater than comparisons, even though there's nothing wrong with allowing them. As it turns out, the machinery for them was already implemented, they were just not put into the GraphQL schema.I didn't do anything about API versioning in this PR since we've had other examples of GraphQL schema changes (e.g., child and and/or filters) that didn't change the API version either.
Fixes #4282