Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: Improve predictability of the time for each batch during pruning #4152

Merged
merged 1 commit into from
Nov 9, 2022
Merged

store: Improve predictability of the time for each batch during pruning #4152

merged 1 commit into from
Nov 9, 2022

Conversation

lutter
Copy link
Collaborator

@lutter lutter commented Nov 9, 2022

No description provided.

leoyvens
leoyvens reviewed Nov 9, 2022
View reviewed changes
Copy link
Collaborator

@leoyvens leoyvens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the vid >= $3 and limit $4 on the outer query redundant right? So we could maybe remove them or explain in the comment that they are redundant.

@lutter
Copy link
Collaborator Author

lutter commented Nov 9, 2022

This makes the vid >= $3 and limit $4 on the outer query redundant right? So we could maybe remove them or explain in the comment that they are redundant.

Yes, they are redundant; I was in a bit of a belt and suspenders mood with that. I'll expand the comment

@lutter lutter merged commit aea5b57 into master Nov 9, 2022
@lutter lutter deleted the lutter/prune branch November 9, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoyvens leoyvens leoyvens left review comments

@mangas mangas mangas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lutter @mangas @leoyvens