Ship envsubst
with the Docker image to facilitate TOML templating
#3974
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
envsubst
takes care of all foreseeable templating needs that we might face for TOML configuration files.From all
envsubst
implementations that I could find, I selected https://github.com/a8m/envsubst because it seemed to be the most complete and well adopted. More fully-fledged templating engines like http://www.confd.io/ are interesting but probably overkill.Here's an example of a configuration pattern that
envsubst
can deal with, while our current variable expansion logic can't:Closes #3946.