-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Management and Validation #2682
Conversation
@tilacog Is this missing tests? What will be the testing strategy for this? I think unit tests might work fine. |
Yes, there should be tests. I think we could reuse the subgraphs we already have defined for integration tests here... and even writing new subgraphs to test new features as well. |
@tilacog What about the error message returned to graph-cli? We should make sure an informative message is being returned by the deploy json-rpc and is being printed by graph-cli. |
I'll link a companion PR for |
7bd31d5
to
289b3a7
Compare
9512e52
to
349cbb2
Compare
This PR adds:
TODO:
specVersion
, I'll do that now.SubgraphFeatures
enum usingcamelCase
names.Fixes: #2715