This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 73
Compact blocks #819
Draft
cyriltovena
wants to merge
18
commits into
main
Choose a base branch
from
feat/compact
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Compact blocks #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
commented
Jul 6, 2023
} | ||
profileWriter := newProfileWriter(profileFile) | ||
|
||
// todo new symbdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kolesnikovae see how we wrap the rowIterator to remap each rows value...
I'm leaving symdb alone for now as you're working on this, I'll start testing and benchmarking this for now.
Latest progress:
Takes 22m to compact the latest 4 blocks directly from object store. |
Local compaction (download blocks first) takes 1m20. https://flamegraph.com/share/1f92c67b-208c-11ee-85f3-ba195a7e5c95 |
We just need to rewrite stacktraceids and ingest symbols and then add the files meta and that should be good to go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still a lot to do: