Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All internal components are renamed to Develocity #678

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

erichaagdev
Copy link
Member

This PR updates all internal references from Gradle Enterprise to Develocity.

Much of this is just a simple rename of ge and gradle enterprise to develocity, but there were a few occurrences where this wasn't the case. I have outlined any noteworthy and exceptional cases below:

  • The bundled Maven extension was renamed from configure-gradle-enterprise-maven-extension to configure-develocity-maven-extension (it still configures both)
  • All system properties passed to configure-develocity-maven-extension had their prefixes updated from com.gradle.enterprise.build-validation to develocity.build-validation
    • For Gradle, this has already been done, setting aside the fact that Gradle now configures the init script using environment variables
    • I made certain to not rename the system properties that are configuring the "Gradle Enterprise" Maven extension directly, such as gradle.enterprise.url and gradle.enterprise.allowUntrustedServer as these must remain for as long as we support using the GE Maven extension with the scripts
  • All links pointing to documentation in Gradle.md or Maven.md has been updated from https://github.com/gradle/gradle-enterprise-build-validation-scripts/blob to the special short form redirect https://gradle.com/bvs

What remains are things that cannot yet be updated. This primarily includes all references to the repository, Gradle Enterprise distributions, bundled GE extension.

@erichaagdev erichaagdev requested review from etiennestuder, jthurne and a team November 11, 2024 18:43
@erichaagdev erichaagdev self-assigned this Nov 11, 2024
Copy link
Member

@ribafish ribafish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@jprinet jprinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, just a question about a GE artifact

build.gradle.kts Show resolved Hide resolved
@erichaagdev erichaagdev force-pushed the erichaagdev/internal-develocity branch from 6a34bea to 2ee4a95 Compare December 19, 2024 22:02
@erichaagdev erichaagdev force-pushed the erichaagdev/internal-develocity branch from 2ee4a95 to 81ebb9e Compare December 20, 2024 14:50
Copy link
Member

@etiennestuder etiennestuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Eric.

@erichaagdev erichaagdev merged commit 547a868 into main Dec 20, 2024
4 checks passed
@erichaagdev erichaagdev deleted the erichaagdev/internal-develocity branch December 20, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When linking to documentation the short link is not always used
4 participants