-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add agent modes to Maven plugin #260
Comments
Concrete use case that will hopefully be solved by this issue : allowing Spring native agent sample to remove this usage of Unrelated : I am quite puzzled by the DevXP people get with everything in red in the IDE : I think this is related to our usage of a Maven extension to parse the XML. @lazar-mitrovic Could you please detail why this is needed? I would like to explore if there is a path where at least most common parts of the XML config can discoverable and not in red like that. |
The reason why those elements are in red is because the generated When building a Maven plugin with Maven, those are taken from the Javadoc. In the case of our Gradle-based build, I'm not sure yet what is the missing piece that makes them to be empty. |
Sorry, I misread your comment. What I described would cause the existing config elements to not have documentation (eg by pressing F1).
One possible workaround would be to add |
So after the refactoring, will users have proper autocompletion and not anymore everything in red in IDEs? |
Yes, as part of this task, |
…ault (#12635) Motivation: See #12601 for more detailed information. Modifications: - Switch Netty 5 to runtime class initialization when used in a `native-image`. - Remove native-image substitutions. These are no longer necessary as Netty is now initialized at runtime. - Add a script to automatically collect conditional native-image metadata by running the Netty tests with the `native-image-agent` attached. - Set the default of `PlatformDependent0.IS_EXPLICIT_TRY_REFLECTION_SET_ACCESSIBLE` to `true` when running in a `native-image`. - Remove the `svm` artifact from Netty dependencies - this is no longer needed as Netty doesn't have substitutions. - Use the Maven plugin provided by [Native Build Tools](https://github.com/graalvm/native-build-tools) instead of the old GraalVM Maven plugin. The previous plugin has been deprecated in favor of the one provided by the NBT. - Bump the GraalVM version used in the gates to GraalVM 22.1, Java 17 Result: Hopefully, native-image support should now be easier to maintain. All that's required to regenerate the metadata is to run the `native-image/ni_metadata.sh` script. In the initial testing with the Spring native samples, we noticed a minor increase in the resulting image size. Automatically generating metadata can be done even cleaner in the future, once the Native Build Tools Maven Plugin gets support for the new conditional metadata collection mode of the agent: graalvm/native-build-tools#260
Similar to #230 for Gradle plugin, we should implement something similar for the Maven plugin:
The text was updated successfully, but these errors were encountered: