Skip to content

Commit

Permalink
DisableImplicitFSharpCoreReference for dependabot
Browse files Browse the repository at this point in the history
  • Loading branch information
goswinr committed Nov 24, 2024
1 parent 10ebd9d commit 9beb93e
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 5 deletions.
3 changes: 3 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ updates:
interval: "weekly"

# Update to newer NuGet dependencies
# to work on FSharp.Core too the fsproj needs : <DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
# and <PackageReference Include="FSharp.Core" Version= ...
# see https://github.com/dependabot/dependabot-core/issues/10883
- package-ecosystem: "nuget"
directory: "/"
schedule:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/releaseNuget.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Publish NuGet Package
on:
push:
tags:
- '*.*.*'
- '[0-9]+.[0-9]+.[0-9]+'

jobs:
publish:
Expand All @@ -22,4 +22,4 @@ jobs:
run: dotnet build --configuration Release

- name: Publish NuGet package
run: dotnet nuget push ./Src/bin/Release/AvalonLog.${{ github.ref_name}}.symbols.nupkg --api-key ${{ secrets.NUGET_API_KEY }} --source https://api.nuget.org/v3/index.json
run: dotnet nuget push ./Src/bin/Release/*.symbols.nupkg --api-key ${{ secrets.NUGET_API_KEY }} --source https://api.nuget.org/v3/index.json
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [0.3.1] - 2021-09-26
- Update Xml doc-strings


[Unreleased]: https://github.com/goswinr/AvalonLog/compare/0.17.0...HEAD
[0.17.0]: https://github.com/goswinr/AvalonLog/compare/0.16.0...0.17.0
[0.16.0]: https://github.com/goswinr/AvalonLog/compare/0.15.8...0.16.0
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ this will produce

![WPF window](https://raw.githubusercontent.com/goswinr/AvalonLog/main/Docs/img/HelloWorld.png)


For C# there is
```csharp
public void AppendWithBrush(SolidColorBrush br, string s)
Expand Down
4 changes: 3 additions & 1 deletion Src/AvalonLog.fsproj
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
<OtherFlags>$(OtherFlags)--warnon:3390</OtherFlags><!-- warnon:3390 is to verify xml docstrings https://devblogs.microsoft.com/dotnet/announcing-f-5/#improved-compiler-analysis-for-library-authors -->
<OtherFlags>$(OtherFlags) --warnon:1182</OtherFlags><!-- 1182: warn on unused variables -->
<Configuration>Release</Configuration>
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference> <!--see .github/dependabot.yml -->
</PropertyGroup>

<PropertyGroup>
Expand Down Expand Up @@ -59,8 +60,9 @@
</PropertyGroup>

<ItemGroup>
<!-- Fesh.Revit depends on this repo and if FSharp.Core is not on the same version here there is an assembly loading error -->
<PackageReference Include="FSharp.Core" Version="9.0.100" /> <!-- use 'Include' syntax, see .github/dependabot.yml -->
<PackageReference Include="AvalonEditB" Version="2.4.0" />
<PackageReference Update="FSharp.Core" Version="9.0.100" /> <!-- needs to be aligned with Fesh.Revit -->
<PackageReference Include="Ionide.KeepAChangelog.Tasks" Version="0.1.8" PrivateAssets="all" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
<!-- https://docs.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files#controlling-dependency-assets -->
Expand Down

0 comments on commit 9beb93e

Please sign in to comment.