Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config.yml #495

Merged
merged 2 commits into from
Jul 1, 2019
Merged

Update config.yml #495

merged 2 commits into from
Jul 1, 2019

Conversation

elithrar
Copy link
Contributor

@elithrar elithrar commented Jul 1, 2019 •
edited
Loading

Build config update - name key steps, add [optional] lint step.

Adds SKIP_GOLINT=1 to the mux build due to linter errors that would break the public API:

➜  golint
mux.go:368:5: error var SkipRouter should have name of the form ErrFoo

@elithrar elithrar self-assigned this Jul 1, 2019
@elithrar elithrar merged commit d83b6ff into master Jul 1, 2019
@elithrar elithrar deleted the elithrar/circleci branch July 1, 2019 20:26
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@elithrar elithrar

Labels
build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elithrar