Use req.URL.EscapedPath() instead of getPath(req) #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change drops support of go < 1.5. go1.5 has been officially unsupported since go1.7 was released 2016/08/15.
|
I am OK with this, and this makes more sense than the other PR.
1.5 has been around for a long while.
…On Tue, Oct 17, 2017 at 10:37 PM Mike Busch ***@***.***> wrote:
This change drops support of go < 1.5. go1.4 has been officially
unsupported <https://golang.org/doc/devel/release.html#policy> since
go1.6 was released 2016/02/17.
The PR was motivated by a bug I discovered, where req.RequestURI was
returning "", so my router was failing to route on the escaped path.
Very open to thoughts and/feedback on how to proceed. Thanks!
------------------------------
You can view, comment on, or merge this pull request online at:
#306
Commit Summary
- use req.URL.EscapedPath() instead of getPath(req)
File Changes
- *M* mux.go <https://github.com/gorilla/mux/pull/306/files#diff-0>
(25)
- *M* regexp.go <https://github.com/gorilla/mux/pull/306/files#diff-1>
(6)
Patch Links:
- https://github.com/gorilla/mux/pull/306.patch
- https://github.com/gorilla/mux/pull/306.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#306>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABIcLbYkeXV5VmuwpF2TwqtYRUhSk8iks5stQ_8gaJpZM4P8yMy>
.
|
|
Agreed
… On Oct 17, 2017, at 19:32, Matt Silverlock ***@***.***> wrote:
I am OK with this, and this makes more sense than the other PR.
1.5 has been around for a long while.
On Tue, Oct 17, 2017 at 10:37 PM Mike Busch ***@***.***>
wrote:
> This change drops support of go < 1.5. go1.4 has been officially
> unsupported <https://golang.org/doc/devel/release.html#policy> since
> go1.6 was released 2016/02/17.
>
> The PR was motivated by a bug I discovered, where req.RequestURI was
> returning "", so my router was failing to route on the escaped path.
>
> Very open to thoughts and/feedback on how to proceed. Thanks!
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #306
> Commit Summary
>
> - use req.URL.EscapedPath() instead of getPath(req)
>
> File Changes
>
> - *M* mux.go <https://github.com/gorilla/mux/pull/306/files#diff-0>
> (25)
> - *M* regexp.go <https://github.com/gorilla/mux/pull/306/files#diff-1>
> (6)
>
> Patch Links:
>
> - https://github.com/gorilla/mux/pull/306.patch
> - https://github.com/gorilla/mux/pull/306.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#306>, or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AABIcLbYkeXV5VmuwpF2TwqtYRUhSk8iks5stQ_8gaJpZM4P8yMy>
> .
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
chrisdostert
added a commit
to chrisdostert/mux
that referenced
this pull request
Nov 9, 2017
gorilla#306 changed UseEncodedPath to use native go encoded path handling so cautions in it's docs are no longer applicable.
elithrar
pushed a commit
that referenced
this pull request
Nov 9, 2017
#306 changed UseEncodedPath to use native go encoded path handling so cautions in it's docs are no longer applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change drops support of go < 1.5. go1.4 has been officially unsupported since go1.6 was released 2016/02/17.
The PR was motivated by a bug I discovered, where
req.RequestURIwas returning"", so my router was failing to route on the escaped path.Very open to thoughts and/feedback on how to proceed. Thanks!