Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] : the link for gorilla mux logo is broken #710

Closed
SagarSingh2003 opened this issue Jul 13, 2023 · 0 comments · Fixed by #724
Closed

[bug] : the link for gorilla mux logo is broken #710

SagarSingh2003 opened this issue Jul 13, 2023 · 0 comments · Fixed by #724
Labels
bug

Comments

@SagarSingh2003
Copy link

Describe the bug

A clear and concise description of what the bug is.

  • The logo of gorilla mux is not showing up in the readme file

gorillamux

…
…

Versions

Go version: go version
package version: run git rev-parse HEAD inside the repo

…

Steps to Reproduce

How can the bug be triggered?

…

Expected behavior

What output or behaviour were you expecting instead?

…

Code Snippets

A minimum viable code snippet can be useful! (use backticks to format it).

…
@SagarSingh2003 SagarSingh2003 changed the title [bug] [bug] : the link for gorilla mux logo is broken Jul 13, 2023
@shamkarthik shamkarthik mentioned this issue Jul 25, 2023
Merged
10 tasks
coreydaley pushed a commit that referenced this issue Jul 25, 2023
@shamkarthik
Updated the logo in README.md (#724)
753457f 
<!--
For Work In Progress Pull Requests, please use the Draft PR feature,
see https://github.blog/2019-02-14-introducing-draft-pull-requests/ for
further details.

     For a timely review/response, please avoid force-pushing additional
     commits if your PR already received reviews or comments.

     Before submitting a Pull Request, please ensure that you have:
- 📖 Read the Contributing guide:
https://github.com/gorilla/.github/blob/main/CONTRIBUTING.md
- 📖 Read the Code of Conduct:
https://github.com/gorilla/.github/blob/main/CODE_OF_CONDUCT.md

     - Provide tests for your changes.
     - Use descriptive commit messages.
	 - Comment your code where appropriate.
	 - Squash your commits
     - Update any related documentation.

     - Add gorilla/pull-request-reviewers as a Reviewer
-->

## What type of PR is this? (check all applicable)

- [ ] Refactor
- [ ] Feature
- [ ] Bug Fix
- [ ] Optimization
- [x] Documentation Update

## Description

## Related Tickets & Documents

<!--
For pull requests that relate or close an issue, please include them
below. We like to follow [Github's guidance on linking issues to pull
requests](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue).

For example having the text: "closes #1234" would connect the current
pull
request to issue 1234.  And when we merge the pull request, Github will
automatically close the issue.
-->

- Related Issue #710
- Closes #710

## Added/updated tests?

- [ ] Yes
- [ ] No, and this is why: _please replace this line with details on why
tests
      have not been included_
- [ ] I need help with writing tests

## Run verifications and test

- [ ] `make verify` is passing
- [ ] `make test` is passing

Signed-off-by: Sham Karthik S <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated the logo in README.md shamkarthik/mux
1 participant
@SagarSingh2003