Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPT-96] Update go version & add verification/testing tools #166

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

apoorvajagtap
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Related Tickets & Documents

  • Related Issue #
  • Closes #

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

Run verifications and test

  • make verify is passing
  • make test is passing

@apoorvajagtap apoorvajagtap changed the title Update go version & add verification/testing tools [GPT-96] Update go version & add verification/testing tools Jul 25, 2023
@apoorvajagtap
Copy link
Member Author

@coreydaley For this repo, multiple golint & gosec errors were reported, which I have silenced for now, as it would have introduced too many changes in one PR. But, this appears to be something we might need to focus on during the next steps.

@apoorvajagtap apoorvajagtap force-pushed the GPT-95 branch 2 times, most recently from 33ce071 to d61b122 Compare July 25, 2023 11:12
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@32c27b0). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage        ?   90.93%           
=======================================
  Files           ?        5           
  Lines           ?      353           
  Branches        ?        0           
=======================================
  Hits            ?      321           
  Misses          ?       25           
  Partials        ?        7           

README.md Outdated Show resolved Hide resolved
Co-authored-by: Corey Daley <[email protected]>
Signed-off-by: Apoorva Jagtap <[email protected]>
@coreydaley coreydaley merged commit 15d47ec into gorilla:main Jul 25, 2023
@apoorvajagtap apoorvajagtap deleted the GPT-95 branch July 26, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants