Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported versions: remove Python 3.7 and add Python 3.12 #1017

Merged
merged 7 commits into from
Oct 10, 2023

Conversation

msabramo
Copy link
Contributor

as described at https://devguide.python.org/versions/

Fixes: GH-971

There's probably more that needs to be done with GitHub Actions, README.rst, changelog.rst, but this is a start...

@BoboTiG
Copy link
Collaborator

BoboTiG commented Oct 10, 2023

You can grep the whole source code with "3.7" & "37" and adapt here and there.

@msabramo msabramo force-pushed the update-supported-versions branch from 4ed9b8d to e476b7f Compare October 10, 2023 18:14
@msabramo msabramo changed the title tox.ini: Update supported versions Update supported versions: remove Python 3.7 and add Python 3.12 Oct 10, 2023
It seems tox doesn't support it yet.
@msabramo
Copy link
Contributor Author

I seeked and destroyed I think the relevant cases of 3.7 and 37. What's remaining seems okay to keep I guess:

(.venv)
abramowi at Marcs-MacBook-Pro-3 in ~/Code/OpenSource/watchdog (update-supported-versions)
$ ag '3\.7|37'
tests/test_observers_winapi.py
117:        File "C:\Python37-32\lib\threading.py", line 926, in _bootstrap_inner

changelog.rst
11:- Drop support for Python 3.7.
224:- Avoid deprecated ``PyEval_InitThreads`` on Python 3.7+ (`#746 <https://github.com/gorakhargosh/watchdog/pull/746>`__)
343:- [inotify] Fixed the way ``OSError`` are re-raised (`#377 <https://github.com/gorakhargosh/watchdog/issues/377>`__)
375:- [bsd] Improved the platform detection (`#378 <https://github.com/gorakhargosh/watchdog/pull/378>`__)
376:- [inotify] Fixed a crash when the root directory being watched by was deleted (`#374 <https://github.com/gorakhargosh/watchdog/pull/374>`__)
382:- [windows] Fixed the ``FILE_LIST_DIRECTORY`` constant (`#376 <https://github.com/gorakhargosh/watchdog/pull/376>`__)

src/watchdog_fsevents.c
724:// PyEval_InitThreads() does nothing as of Python 3.7 and is deprecated in 3.9.

@BoboTiG
Copy link
Collaborator

BoboTiG commented Oct 10, 2023

Maybe also tweak:

@msabramo
Copy link
Contributor Author

msabramo commented Oct 10, 2023

Haha I was just going to say that I just remembered that ag ignores dotfiles and dot directories by default, so I think I missed the GitHub Actions stuff.

(.venv)
abramowi at Marcs-MacBook-Pro-3 in ~/Code/OpenSource/watchdog (update-supported-versions)
$ ag '3\.7|37' .github/workflows
.github/workflows/tests.yml
44:          - "3.7"

@BoboTiG
Copy link
Collaborator

BoboTiG commented Oct 10, 2023

I think you can add 3.12 to the CI + tox. It will fail for a time, but then it will run automagically when tox will support 3.12 (without having us to check for updates on their side).

changelog.rst Show resolved Hide resolved
@BoboTiG BoboTiG merged commit 6cdf07e into gorakhargosh:master Oct 10, 2023
23 of 24 checks passed
@msabramo msabramo deleted the update-supported-versions branch October 10, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.7 support removal
2 participants