tests: xfail tests until we work on them (#975)

* xfail tests until we work on them * more xfail for pypy * Apply suggestions from code review --------- Co-authored-by: Mickaël Schoentgen <[email protected]>
gorakhargosh · Mar 15, 2023 · ddb9bd1 · ddb9bd1
1 parent 344f342
commit ddb9bd1
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/tests/test_0_watchmedo.py b/tests/test_0_watchmedo.py
@@ -151,6 +151,10 @@ def test_auto_restart_on_file_change(tmpdir, capfd):
     assert trick.restart_count == 3
 
 
+@pytest.mark.xfail(
+    condition=sys.platform.startswith(("win", "darwin")) or sys.implementation.name == "pypy",
+    reason="known to be problematic, see #973",
+)
 def test_auto_restart_on_file_change_debounce(tmpdir, capfd):
     """Simulate changing 3 files quickly and then another change later.
 
@@ -173,7 +177,19 @@ def test_auto_restart_on_file_change_debounce(tmpdir, capfd):
     assert trick.restart_count == 2
 
 
-@pytest.mark.parametrize("restart_on_command_exit", [True, False])
+@pytest.mark.parametrize(
+    "restart_on_command_exit",
+    [
+        True,
+        pytest.param(
+            False,
+            marks=pytest.mark.xfail(
+                condition=sys.platform.startswith(("win", "darwin")),
+                reason="known to be problematic, see #972",
+            ),
+        ),
+    ],
+)
 def test_auto_restart_subprocess_termination(tmpdir, capfd, restart_on_command_exit):
     """Run auto-restart with a script that terminates in about 2 seconds.
 

diff --git a/tests/test_emitter.py b/tests/test_emitter.py
@@ -133,6 +133,7 @@ def test_create():
         assert isinstance(event, FileClosedEvent)
 
 
+@pytest.mark.xfail(reason="known to be problematic")
 @pytest.mark.skipif(
     not platform.is_linux(), reason="FileCloseEvent only supported in GNU/Linux"
 )