Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add map padding #232

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add map padding #232

wants to merge 5 commits into from

Conversation

illuminati1911
Copy link
Contributor

This PR adds map padding support to both regular map view as well as Android auto/Carplay map views.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

jokerttu
jokerttu requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@jokerttu jokerttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use flutter's EdgeInsets class instead of new MapPadding class

android/src/main/kotlin/com/google/maps/flutter/navigation/GoogleMapView.kt Show resolved Hide resolved
lib/src/google_navigation_flutter_platform_interface.dart Outdated Show resolved Hide resolved
lib/src/google_navigation_flutter_platform_interface.dart Outdated Show resolved Hide resolved
lib/src/method_channel/common_auto_view_api.dart Outdated Show resolved Hide resolved
lib/src/method_channel/common_view_api.dart Outdated Show resolved Hide resolved
lib/src/method_channel/convert/map_padding.dart Outdated Show resolved Hide resolved
lib/src/types/navigation_view_types.dart Outdated Show resolved Hide resolved
ios/google_navigation_flutter/Sources/google_navigation_flutter/MapConfiguration.swift Outdated Show resolved Hide resolved
jokerttu
jokerttu approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@jokerttu jokerttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jokerttu jokerttu marked this pull request as ready for review December 10, 2024 09:16
jokerttu
jokerttu requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@jokerttu jokerttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's implement getPadding behaviour to support integration tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jokerttu jokerttu jokerttu requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@jokerttu jokerttu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illuminati1911 @jokerttu