-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
744d42a
to
bce4d6e
Compare
@@ -0,0 +1,1932 @@ | |||
// Generated by the protocol buffer compiler. DO NOT EDIT! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these files with Proto
suffix are generated automatically, so don't waste your time on them ⏰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about excluding generated code from source control, by marking them in .gitignore
? And maybe add a command for the code generation in the README
. This way it will reduce clutter and prevent the generated / actual source code from ever going out of sync :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks! I think it's good idea, I will add entire autogen
folder into .gitignore
bce4d6e
to
f4e825c
Compare
Perhaps controversial, actually the internal guidance is to prefer |
6682344
to
9660862
Compare
@@ -4,6 +4,17 @@ A graph based query language on top of [dagger](https://github.com/google/dagger | |||
|
|||
Dagger Query can be used to investigate the dagger dependency graph. | |||
|
|||
## Before you start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this documentation to the readme is a really good idea.
Add protocol buffer models for representing bindings, dependencies and graph
All models constructed with
proto2
. This is preferred because inproto3
all fields are optional which can add ambiguity.Binding
is represented by its unique string-key.Dependency
model represents an edge in graph which always contains target node.BindingGraph
contains a mapadjacency_list
which simply matches binding or component (access it by string representation of key) to list with other bindings.