Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python_mono_repo): add support for grafeas #1888

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 30, 2023

This PR fixes the issue where the owlbot post processor fails for grafeas because it runs a nox session which expects a directory google in the package root. See build log here. See the failure here.

See stack trace below

nox > black docs google tests noxfile.py setup.py
Usage: black [OPTIONS] SRC ...
Try 'black -h' for help.

Error: Invalid value for 'SRC ...': Path 'google' does not exist.
nox > Command black docs google tests noxfile.py setup.py failed with exit code 2
nox > Session format failed.
2023-10-29 14:42:48,408 synthtool [ERROR] > Failed executing nox -s format:

None
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/local/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/synthtool/synthtool/languages/python_mono_repo.py", line 263, in <module>
    owlbot_main(package_dir)
  File "/synthtool/synthtool/languages/python_mono_repo.py", line 251, in owlbot_main
    synthtool.shell.run(
  File "/synthtool/synthtool/shell.py", line 39, in run
    raise exc
  File "/synthtool/synthtool/shell.py", line 27, in run
    return subprocess.run(
  File "/usr/local/lib/python3.10/subprocess.py", line 524, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['nox', '-s', 'format']' returned non-zero exit status 1.

@parthea parthea marked this pull request as ready for review October 30, 2023 14:45
@parthea parthea merged commit 14b6f98 into master Oct 30, 2023
9 checks passed
@parthea parthea deleted the add-support-for-grafeas branch October 30, 2023 14:59
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Oct 30, 2023
This PR updates the post processor image to the latest one which is
`gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo@sha256:11c56ce03d0ada22086790a5f4a3b552b304a1d71554cfeda3372885d390984a`.

The latest image includes the following fixes:
googleapis/synthtool#1888

Run the following commands to obtain the latest sha256
```
docker pull gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest
```

```
partheniou@partheniou-vm-3:~$ docker inspect --format='{{.RepoDigests}}' gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest
[gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo@sha256:11c56ce03d0ada22086790a5f4a3b552b304a1d71554cfeda3372885d390984a]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants